8000 functional tests: disable problematic tests by iaguis · Pull Request #2535 · rkt/rkt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

functional tests: disable problematic tests #2535

Merged
merged 1 commit into from
Apr 28, 2016

Conversation

iaguis
Copy link
Member
@iaguis iaguis commented Apr 28, 2016

We just enabled functional testing for the KVM flavor but there're two
tests that currently don't pass: TestDockerVolumeSemantics and
TestNetLongName.

Disable building the files where those tests are included on the KVM
flavor for now.

We just enabled functional testing for the KVM flavor but there're two
tests that currently don't pass: TestDockerVolumeSemantics and
TestNetLongName.

Disable building the files where those tests are included on the KVM
flavor for now.
@jellonek
Copy link
Contributor

LGTM

@@ -12,7 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// +build coreos src kvm
// TODO: fix TestDockerVolumeSemantics on KVM and add the "kvm" build tag again
// +build coreos src
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit annoying to disable other tests in that file...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree 😞

8000

@alban alban merged commit a44c381 into rkt:master Apr 28, 2016
jellonek added a commit to intelsdi-x/rkt that referenced this pull request Apr 29, 2016
iaguis pushed a commit to kinvolk/rkt that referenced this pull request May 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0