Release v1.4.0 #2431
Release v1.4.0 #2431
Conversation
| @@ -455,7 +455,7 @@ func TestNetTemplates(t *testing.T) { | |||
| Type: "ptp", | |||
| Ipam: ipamTemplateT{ | |||
| Type: "host-local", | |||
| Subnet: "11.11.3.0/24", | |||
| Subnet: "11.11.4.0/24", | |||
There was a problem hiding this comment.
oops, the script mistakenly changed this IP
cebd5b3 to
956f27b
Compare
|
|
||
| #### New features and UX changes | ||
|
|
||
| - Add `--user`/`--group` option to rkt run/prepare ([#2419](https://github.com/coreos/rkt/pull/2419)). This option allows overriding the user/group specified in the image manifest. | ||
| - config: add config subcommand ([2405](https://github.com/coreos/rkt/pull/2405)). This new subcommand prints the current rkt configuration. It can be used to get i.e. authentication credentials. |
There was a problem hiding this comment.
In the previous release notes, we used a # before the number. Example:
(#2405)
956f27b to
4098621
Compare
| - Ensure that the initial name and labels used for discovery match the name and labels in the Image Manifest as specified in the appc spec ([#2311](https://github.com/coreos/rkt/pull/2311)). Users wanting the latest image should use `rkt prepare/run/fetch example.com/aci` without any labels. If the discovery server supports the "latest" pattern, the user can bypass a locally cached image in the store and fetch an updated image using `rkt prepare/run/fetch --no-store example.com/aci` option. | ||
| - run: add user/group app flags ([2419](https://github.com/coreos/rkt/pull/2419)). This adds the `--user`/`--group` options to rkt run/prepare allowing to override the user/group specified in the image manifest. | ||
|
|
||
| - gc: Add flag 'mark-only' to mark garbage pods without deleting them ([2400](https://github.com/coreos/rkt/pull/2400), [2402](https://github.com/coreos/rkt/pull/2402)). This new flag moves exited/aborted pods to the exited-garbage/garbage directory but does not delete them. A third party application can use `rkt gc --mark- to mark the time when a pod is not running. |
There was a problem hiding this comment.
I'd say "to mark exited pods as garbage without deleting them"
4098621 to
3bdfb66
Compare
|
|
||
| - gc: Add flag 'mark-only' to mark garbage pods without deleting them ([2400](https://github.com/coreos/rkt/pull/2400), [2402](https://github.com/coreos/rkt/pull/2402)). This new flag moves exited/aborted pods to the exited-garbage/garbage directory but does not delete them. A third party application can use `rkt gc --mark- to mark the time when a pod is not running. | ||
|
|
||
| - kvm: Add support for capabilities limitation ([2222](https://github.com/coreos/rkt/pull/2222)). By default kvm flavor has got enabled every capability inside pod. This patch adds support for a restricted set of capabilities inside a rkt-kvm pod. |
There was a problem hiding this comment.
"Add support for app capabilities limitation"
3bdfb66 to
3c491f8
Compare
|
I don't see #2402 mentioned on the changelog |
|
|
||
| #### Improved documentation | ||
|
|
||
| - documentation: remove superfluous dash ([#2413](https://github.com/coreos/rkt/pull/2413)). |
There was a problem hiding this comment.
Usually we're not that detailed with small changes. We just say doc improvements or something like that.
There was a problem hiding this comment.
fixed, squashed in one line
3c491f8 to
56c34f1
Compare
|
|
||
| - kvm: Add support for app capabilities limitation ([#2222](https://github.com/coreos/rkt/pull/2222)). By default kvm flavor has got enabled every capability inside pod. This patch adds support for a restricted set of capabilities inside a rkt-kvm pod. | ||
|
|
||
| - kvm: new volumes support ([#2328](https://github.com/coreos/rkt/pull/2328)). This provides new volumes support based on bind mounting volumes in time of rootfs preparation for the kvm flavor. |
There was a problem hiding this comment.
oh, right, mounting single files as volumes was not working: bind-mounting files works on Linux but mounting regular files as a p9 mount does not work. The new implementation makes it work.
There was a problem hiding this comment.
I suggest:
kvm: refactor volumes support (#2328). This allows users to share regular files as volumes in addition to directories.
There was a problem hiding this comment.
I think this should be in the "bug fix" section.
|
@iaguis #2402 is mentioned along with #2400 here https://github.com/coreos/rkt/pull/2431/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR9 |
|
|
||
| - documentation: remove superfluous dash ([#2413](https://github.com/coreos/rkt/pull/2413)). | ||
|
|
||
| - functional tests: Add new test with systemd-proxyd ([#2257](https://github.com/coreos/rkt/pull/2257)). Adds a new test and documentation how to use systemd-proxyd with rkt pods. |
There was a problem hiding this comment.
Btw, my tests yesterday (https://gist.github.com/alban/b79c699e60ee7ce5ade64e167d418bb1) show that it is not working on old distributions with an old systemd. We should report a bug about this to disable the tests when systemd-proxyd is not installed or something.
818ca5b to
e92c3b0
Compare
|
|
||
| - rkt: calculate real dataDir path ([#2399](https://github.com/coreos/rkt/pull/2399)). Fixes garbage collection when the data directory specified by `--dir` contains a symlink component. | ||
|
|
||
| - stage1/init: fix docker volume semantics ([#2409](https://github.com/coreos/rkt/pull/2409)). Fixes a bug in docker volume semantics when rkt runs with the option `--pod-manifest`. |
There was a problem hiding this comment.
Should mention what is this docker volume semantic we are talking about.
When a Docker image exposes a mount point that is not mounted by a host volume, Docker volume semantics expects the files in the directory to be available to the application. This was partially fixed in rkt 1.3.0 via #2315 but the bug remained when rkt runs with the option
--pod-manifest. This is now fully fixed.
692c1bb to
d91f27d
Compare
|
|
||
| #### New features and UX changes | ||
|
|
||
| - Add `--user`/`--group` option to rkt run/prepare ([#2419](https://github.com/coreos/rkt/pull/2419)). This option allows overriding the user/group specified in the image manifest. | ||
| - config: add config subcommand ([#2405](https://github.com/coreos/rkt/pull/2405)). This new subcommand prints the current rkt configuration. It can be used to get i.e. authentication credentials. |
There was a problem hiding this comment.
Link to the documentation:
https://github.com/coreos/rkt/blob/master/Documentation/subcommands/config.md
There was a problem hiding this comment.
See rkt's config subcommand documentation.
There was a problem hiding this comment.
fixed
d91f27d to
88f176b
Compare
|
|
||
| - rkt: calculate real dataDir path ([#2399](https://github.com/coreos/rkt/pull/2399)). Fixes garbage collection when the data directory specified by `--dir` contains a symlink component. | ||
|
|
||
| - stage1/init: fix docker volume semantics ([#2409](https://github.com/coreos/rkt/pull/2409)). Fixes a bug in docker volume semantics when rkt runs with the option `--pod-manifest`. When a Docker image exposes a mount point that is not mounted by a host volume, Docker volume semantics expect the files in the directory to be available to the application. This was partially fixed in rkt 1.3.0 via ([#2315](https://github.com/coreos/rkt/pull/2315)) but the bug remained when rkt runs with the option `--pod-manifest`. This is now fully fixed. |
There was a problem hiding this comment.
either put "via" in the parenthesis, or remove the parenthesis
|
|
||
| - rkt/image: check that discovery labels match manifest labels ([#2311](https://github.com/coreos/rkt/pull/2311)). | ||
|
|
||
| - store: fix comment + add link in db test ([#2407](https://github.com/coreos/rkt/pull/2407)). |
There was a problem hiding this comment.
This PR is probably not worth mentioning...
9d80f76 to
00569d7
Compare
|
|
||
| - rkt/image: check that discovery labels match manifest labels ([#2311](https://github.com/coreos/rkt/pull/2311)). | ||
|
|
||
| - store: fix multi process with multi goroutines race on db. ([#2391](https://github.com/coreos/rkt/pull/2391)). This was a bug when multiple `rkt fetch` commands were executed concurrently. |
There was a problem hiding this comment.
Remove the . before the ([#2391](https://github.com/coreos/rkt/pull/2391)).
Currently `build-rir.sh` inherits the environment during the build. This is unnecessary and can actually break the build on a custom host PATH environment. This fixes it.
00569d7 to
6935325
Compare
|
LGTM |
No description provided.