8000 rkt: simplify calculateDataDir · Issue #2421 · rkt/rkt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

rkt: simplify calculateDataDir #2421

Closed
iaguis opened this issue Apr 14, 2016 · 0 comments
Closed

rkt: simplify calculateDataDir #2421

iaguis opened this issue Apr 14, 2016 · 0 comments
Labels
kind/cleanup priority/P2
Milestone
v1.6.0

Comments

@iaguis
Copy link
Member
iaguis commented Apr 14, 2016

Capturing #2399 (comment)

I think we can simplify this if-else cascade a bit:

if dataDir == "" {
  config, err := getConfig()

  if err != nil {
    stderr.PrintE("cannot get configuration", err)
    os.Exit(1)
  }

  dataDir = config.Paths.DataDir
}

cc @sgotti
@iaguis iaguis added this to the v1.5.0 milestone Apr 14, 2016
@iaguis iaguis mentioned this issue Apr 14, 2016
Merged
tmrts added a commit to tmrts/rkt that referenced this issue Apr 19, 2016
@tmrts
rkt: simplify if-else chains and spacing
46a5741 
Refactors the if-else chains for readability

Fixes rkt#2421
@tmrts tmrts mentioned this issue Apr 19, 2016
Merged
tmrts added a commit to tmrts/rkt that referenced this issue Apr 19, 2016
@tmrts
rkt: simplify if-else chains and spacing
bbb8bf4 
Refactors the if-else chains for readability

Fixes rkt#2421
@jonboulle jonboulle modified the milestones: v1.6.0, v1.5.0 Apr 26, 2016
8000
@jonboulle jonboulle assigned tmrts Apr 26, 2016
tmrts added a commit to tmrts/rkt that referenced this issue May 3, 2016
@tmrts
rkt: simplify if-else chains and spacing
8dbd7c1 
Refactors the if-else chains for readability

Fixes rkt#2421
tmrts added a commit to tmrts/rkt that referenced this issue May 11, 2016
@tmrts
rkt: simplify if-else chains and spacing
b8ee0d6 
Refactors the if-else chains for readability

Fixes rkt#2421
tmrts added a commit to tmrts/rkt that referenced this issue May 25, 2016
@tmrts
rkt: simplify if-else chains and spacing
513d1cb 
Refactors the if-else chains for readability

Fixes rkt#2421
@lucab lucab unassigned tmrts Apr 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/cleanup priority/P2
Projects
None yet
Milestone
v1.6.0
Development

No branches or pull requests
3 participants
@iaguis @jonboulle @tmrts
0