Fix SnOverSmFunction printing info. Expose SnOverSm to python; Added .gitignore; Created a python test for S4overS2 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itignore for python, linux, macos, windows and release files.
|
Update: figured out that we were using different notations and that the cosets are correct. There was still a bug in the indexing of SnOverSm that made the fourier transforms of functions over Sn(3) and SnOverSm(3,1) be different (for instance). The second commit includes a fix for this bug and exposes getters and setters for SnOverSmFunctions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Risi,
I've been looking at the repo recently (thanks for making it publicly available!) and I've been trying to have the SnOverSm Fourier transform working. I felt like it'd be nice to contribute/help while working on it.
I've fixed SnOverSmFunction's
strfunction: now it prints both the coset representatives and the function values.I've exposed the SnOverSm class to the python API and I think there's a bug in this class. I've uploaded a test file
test_S4OverS2.py. This test file iterates over all the element of S4 and prints their index for S4OverS2. While each coset contains 2 elements, it seems to me that the cosets are incorrect. For instance, I think that [ 1 3 2 4 ] and [ 2 3 1 4 ] shouldn't belong to the same coset. Am I missing something or do we need to fix the logic behind "element" and "index" inSnOverSm.hpp?Also, I've added a
.gitignoreto avoid pushing unnecessary files in the repo. I've created it with https://gitignore.io using Python, Windows, MacOS, and Linux as keywords. I've also added the python/Snob2.egg-info/, python/build/, and python/dist/ folders, so to keep them clean.Best,
Armando