8000 ZKVM-1390: Update browser-verify example by sashaaldrick · Pull Request #3178 · risc0/risc0 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ZKVM-1390: Update browser-verify example #3178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

ZKVM-1390: Update browser-verify example #3178

wants to merge 8 commits into from

Conversation

sashaaldrick
Copy link
Contributor

updates the browser-verify function 8000 to include:

  • a working host/guest
  • verifier code that is built with wasm-pack
  • example web app which runs the WASM verifier code

@sashaaldrick sashaaldrick requested review from a team as code owners May 22, 2025 13:23
@vercel Vercel
Copy link
vercel bot commented May 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 26, 2025 10:00am
reports-and-benchmarks ⬜️ Ignored (Inspect) Visit Preview May 26, 2025 10:00am

@github-actions github-actions bot changed the title Update browser-verify example ZKVM-1390: Update browser-verify example May 22, 2025
@sashaaldrick
Copy link
Contributor Author
sashaaldrick commented May 22, 2025 •
edited
Loading

I built this example with everything ready to go, so you can just clone and run cd web && npm run dev and you'll be able to verify a real proof in the browser without any other proving necessary. This relies on some "prebuild" files, specifically the /web/public/proof_data and web/public/wasm folders.

I am happy to remove these and explain in the README that proving will need to be carried out first, and then afterwards a wasm-pack command will need to be run. However, I do think that since this is a verify example, it'd be nice to keep the current functionality, and not force people to run proving to be able to try the in-browser verification.

@sashaaldrick sashaaldrick marked this pull request as draft May 22, 2025 13:29
@sashaaldrick
Copy link
Contributor Author

I need to update the CI for this example, once that is done, I'll convert the PR from a draft

@sashaaldrick sashaaldrick force-pushed the sasha/update-browser-verify branch 3 times, most recently from 7dc168c to 7576219 Compare May 22, 2025 15:58
@sashaaldrick sashaaldrick force-pushed the sasha/update-browser-verify branch from fdbbde1 to 6491cfe Compare May 23, 2025 19:32
@sashaaldrick sashaaldrick force-pushed the sasha/update-browser-verify branch from 069a2f6 to a2a4ef0 Compare May 26, 2025 10:00
@sashaaldrick sashaaldrick marked this pull request as ready for review May 27, 2025 08:15
@sashaaldrick
Copy link
Contributor Author
sashaaldrick commented May 27, 2025 •
edited
Loading

@flaub the final CI tests failing seem to be across workflows specifically using CUDA with:

  error occurred in cc-rs: command did not execute successfully (status code exit status: 255): LC_ALL="C" "sccache" "nvcc" "-ccbin=clang++" "-Xcompiler" "-O3" "-Xcompiler" "-ffunction-sections" "-Xcompiler" "-fdata-sections" "-Xcompiler" "-fPIC" "-m64" "-Xcompiler" "--target=x86_64-unknown-linux-gnu" "-I" "/opt/actions-runner/_work/risc0/risc0/risc0/sys/kernels/zkp/cuda" "-I" "/opt/actions-runner/_work/risc0/risc0/risc0/sys/cxx" "-I" "/home/ubuntu/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/sppark-0.1.11/sppark" "-Xcompiler" "-Wall" "-Xcompiler" "-Wextra" "-DFEATURE_BABY_BEAR" "-arch=native" "-diag-suppress=177" "-diag-suppress=2922" "-Xcudafe" "--display_error_number" "-Xcompiler" "-Wno-missing-braces,-Wno-unused-function" "--device-link" "-o" "/opt/actions-runner/_work/risc0/risc0/target/release/build/risc0-circuit-recursion-sys-f46ea2a4c6883611/out/risc0_recursion_cuda_dlink.o" "/opt/actions-runner/_work/risc0/risc0/target/release/build/risc0-circuit-recursion-sys-f46ea2a4c6883611/out/librisc0_recursion_cuda.a"

do you perhaps know what the problem could be here? to me, it seems entirely unrelated to the code I'm pushing but perhaps I've misunderstood something

@sashaaldrick sashaaldrick enabled auto-merge May 28, 2025 18:44
@sashaaldrick
Copy link
Contributor Author

@flaub the final CI tests failing seem to be across workflows specifically using CUDA with:

  error occurred in cc-rs: command did not execute successfully (status code exit status: 255): LC_ALL="C" "sccache" "nvcc" "-ccbin=clang++" "-Xcompiler" "-O3" "-Xcompiler" "-ffunction-sections" "-Xcompiler" "-fdata-sections" "-Xcompiler" "-fPIC" "-m64" "-Xcompiler" "--target=x86_64-unknown-linux-gnu" "-I" "/opt/actions-runner/_work/risc0/risc0/risc0/sys/kernels/zkp/cuda" "-I" "/opt/actions-runner/_work/risc0/risc0/risc0/sys/cxx" "-I" "/home/ubuntu/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/sppark-0.1.11/sppark" "-Xcompiler" "-Wall" "-Xcompiler" "-Wextra" "-DFEATURE_BABY_BEAR" "-arch=native" "-diag-suppress=177" "-diag-suppress=2922" "-Xcudafe" "--display_error_number" "-Xcompiler" "-Wno-missing-braces,-Wno-unused-function" "--device-link" "-o" "/opt/actions-runner/_work/risc0/risc0/target/release/build/risc0-circuit-recursion-sys-f46ea2a4c6883611/out/risc0_recursion_cuda_dlink.o" "/opt/actions-runner/_work/risc0/risc0/target/release/build/risc0-circuit-recursion-sys-f46ea2a4c6883611/out/librisc0_recursion_cuda.a"

do you perhaps know what the problem could be here? to me, it seems entirely unrelated to the code I'm pushing but perhaps I've misunderstood something

okay seems to be fixed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sashaaldrick
0