8000 Add domain support by mcheng89 · Pull Request #500 · revel/revel · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add domain support #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Add domain support #500

wants to merge 4 commits into from

Conversation

mcheng89
Copy link
Contributor
@mcheng89 mcheng89 commented Feb 8, 2014

Support for domain routing

@mcheng89
Copy link
Contributor Author
mcheng89 commented Feb 8, 2014

Add https sni support for multiple https domains

@pushrax
Copy link
Contributor
pushrax commented Feb 9, 2014

I feel like this would be better if the default was *, so you wouldn't have to type it out every time. In addition, doing so would allow for free backwards compatibility.

@mcheng89
Copy link
Contributor Author
mcheng89 commented Feb 9, 2014

@pushrax 👍 Its done

Todo: Handle host for reverse routing

@brendensoares brendensoares modified the milestones: v0.9, v0.10 Feb 10, 2014
@brendensoares
Copy link
Member

I've scheduled this for v0.10 instead of v0.9 because I want to make sure this works in a real world scenario. I do appreciate keeping the unit tests up to date, but I'd like to confirm that it works with real TLS certificates.

Can you confirm this? Also, please target the develop branch in future PRs per our guidelines at https://github.com/robfig/revel/blob/master/CONTRIBUTING.md#how-revel-is-developed

Thanks.

@mcheng89
Copy link
Contributor Author

For the TLS SNI, I have two domains each with their own certificates. I don't get warnings from my browser so I would assume that it's working. The same cert works before the change but it only supported one domain.

Would this also fix #358? I can put sub1.example.com in the routes file to handle a specific sub domain now.

@brendensoares
Copy link
Member

@mcheng89 good to hear. Thanks.

It does seem this PR would allow for separate subdomains. Bonus!

@brendensoares brendensoares modified the milestones: Backlog, v0.10 Feb 19, 2014
@verdverm
Copy link
Contributor

@mcheng89 any updates on this?

I can test it on my server when the PR targets the develop branch per https://github.com/robfig/revel/blob/master/CONTRIBUTING.md#how-revel-is-developed .

@mcheng89 mcheng89 closed this Mar 1, 2014
@mcheng89 mcheng89 mentioned this pull request Mar 1, 2014
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@mcheng89 @pushrax @brendensoares @verdverm
0