8000 Cache store components by adamkleingit · Pull Request #85 · reusablejs/reusable · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Cache store components #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 19, 2019
Merged

Cache store components #85

merged 7 commits into from
Dec 19, 2019

Conversation

adamkleingit
Copy link
Collaborator

Caching previously created components to avoid re-rendering them and losing the store state.
I created the lazy loaded example and it failed when loading first /users then going to / and using the input.
After the fix it works.
I wasn't successful in writing a test for it with lazy loading

@adamkleingit adamkleingit mentioned this pull request Nov 27, 2019
Open
murjam
murjam reviewed Nov 27, 2019
View reviewed changes
@adamkleingit
Copy link
Collaborator Author

Added relative-deps to all examples to test them more easily against the local library

@adamkleingit adamkleingit merged commit 8c19cf4 into master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murjam murjam murjam left review comments

@morsdyce morsdyce morsdyce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamkleingit @morsdyce @murjam
0