Tags: reworkfl/folly
Tags
Creating tag v2016.09.19.00 fbshipit-source-id-base: 16254d301c19fc0a31d1b4060275a87b8bc8e9a1
Creating tag v2016.09.12.01 fbshipit-source-id-base: 7ae43a5d5ba94c8c24fa23a485f18546416e7191
Use the GTest portability headers Summary: Switch all of the uses of `<gtest/gtest.h>` to `<folly/portability/GTest.h>`. This is painful but necessary to get the tests to compile nicely under MSVC. Reviewed By: yfeldblum Differential Revision: D3837300 fbshipit-source-id: 7ae43a5d5ba94c8c24fa23a485f18546416e7191
delete const rvalue reference ctor of folly::Function
Summary:
This code compiles and is causing stack overflow at runtime:
```
using F = folly::Function<void()>;
void foo(F);
F bar;
auto baz = [bar = std::move(bar)] {
foo(std::move(bar));
};
baz();
```
The bug there is that `baz` is missing `mutable` keyword, so when
constructing argument for `foo`, `F(const F&&)` is called, which is selecting
`template <typename Fun> F(Fun&&)` (where `Fun = F const`) and we end up in
an infinite `F<Fun>(Fun&&) <-> F<Fun>(Fun&&, SmallTag|HeapTag)` cycle.
This diff transforms this easy-to-make-bug into compile-time error.
Reviewed By: yfeldblum
Differential Revision: D3810269
fbshipit-source-id: f80a18ab02bd0715d692cf67c3c8943f557c2982
Generalized and polished folly::TokenBucket Summary: Added support for user-defined clock classes, improved comments, and removed part of the std::atomics use that had no effect on thread-safety. Reviewed By: yfeldblum Differential Revision: D3708378 fbshipit-source-id: 1a933c3707c12311584a3b33afd773ee91577167
fix(FBString): fix bugs Summary: fix(FBString): compile error on instantiate `basic_fbstring` with a `Storage` that is not `fbstring_core<E>` Closes facebook#398 Reviewed By: ot Differential Revision: D3714957 Pulled By: yfeldblum fbshipit-source-id: 1c5d2538b674049f7e1872a0b623ec330dc8d7b2
add forgotten apply_tuple_test to Makefile.am Summary: ApplyTupleTest.cpp was never added to Makefile.am. This commit fixes that. Reviewed By: yfeldblum Differential Revision: D3715213 fbshipit-source-id: e1e914438d44affb6fe683614506338c3a3355c6
Use the socket portability layer when needed. Summary: This switches the places in Folly that need to explicitly reference the socket portability implementation to do exactly that. Reviewed By: yfeldblum Differential Revision: D3299984 fbshipit-source-id: 57cd8ebe66c9055aba66581a8c0fcf6c125d96f9
fix HHWheelTimer comment typo Summary: Noticed this while reading the code. Reviewed By: yfeldblum Differential Revision: D3648565 fbshipit-source-id: c00940e5ce91fbc7e5cc6c42e35c5deee3e0bf65
Add a const getter for X509 used in handshake (server-side) Summary: Similar to other getters such as getSSLCertSize, but returns a const X509*. This may be useful to get cert parameters after handshake is complete (or in error). Reviewed By: yfeldblum Differential Revision: D3636598 fbshipit-source-id: 98f0e2987de53d6343541ef0ed588f9ad18390cd
PreviousNext