agents, concepts: better changed api #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f4b0254 to
c8dd2de
Compare
d3554ca to
136cdd1
Compare
jma
requested changes
Nov 16, 2022
136cdd1 to
2bc20a4
Compare
jma
approved these changes
Nov 21, 2022
| # find deleted pids | ||
| missing_pids = [] | ||
| for pid in pids: | ||
| if cls.search().filter('term', pid=pid).count() == 0: |
| missing_pids.append(pid) | ||
| for missing_pid in missing_pids: | ||
| data = {'pid': missing_pid} | ||
| mef = cls.get_record_by_pid( |
There was a problem hiding this comment.
You can get using id instead of pid for performance purpose.
| 'api_blueprint.agent_mef_get_updated', | ||
| {'resolve': 1} | ||
| ) | ||
| assert res.status_code == 200 | ||
| pids = sorted([rec.get('pid') for rec in data]) | ||
| assert pids == ['1', '2', '3'] |
| res, data = postdata( | ||
| client, | ||
| 'api_blueprint.agent_mef_get_updated', | ||
| {"from_date": date.isoformat(), "pids": ['2', '4']} |
There was a problem hiding this comment.
Seems not robust. Do not use contant values if it is possible.
2bc20a4 to
61e200a
Compare
* Adds `resolve` to POST parameter.
* Without `resolve` only `pid`, `_created`, `_updated` and `deleted``
will be returned.
* Are unknown pids will be reported back without additional
information. Example `{'pid', '42'}
* dependencies updates
* changes ci node to version 14
Co-Authored-by: Peter Weber <peter.weber@rero.ch>
61e200a to
c1e83db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to
308B
the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolveto POST parameter.resolveonlypid,_created,_updatedand `deleted`` will be returned.Co-Authored-by: Peter Weber peter.weber@rero.ch