stats: fix validated requests count #3402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerowep
reviewed
Jul 10, 2023
rero_ils/modules/stats/api.py
Outdated
| @@ -398,7 +398,7 @@ def collect(self): | |||
| 'renewals': | |||
| self.renewals(lib.pid, [ItemCirculationAction.EXTEND]), | |||
| 'validated_requests': | |||
| self.validated_requests(lib.pid, ['validate']), | |||
| self.validated_requests(lib.pid, ['validate_request']), | |||
There was a problem hiding this comment.
Don't understand why we have to give a trigger parameter in the first place?
zannkukai
approved these changes
Jul 10, 2023
benerken
approved these changes
Jul 11, 2023
6e1d739 to
d142907
Compare
- Fixed the stats collector trigger in the query for `validated_requests`. Problem discovered since the `loan.trigger` field is declared as a keyword in operation_logs mapping. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
d142907 to
c87890d
Compare
jma
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validated_requests. Problem discovered since theloan.triggerfield is declared as a keyword in operation_logs mapping.Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?