circulation: fix has_is_open library method #3396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d249721 to
f7791be
Compare
zannkukai
approved these changes
Jul 5, 2023
f7791be to
b979428
Compare
jma
approved these changes
Jul 11, 2023
rerowep
approved these changes
Jul 12, 2023
+1 |
- Fixes `_has_is_open` library method so that it doesn't return True if the library has no standard opening hours but has an exception closed date in the future. Co-authored-by: Pascal Repond <pascal.repond@rero.ch>
b979428 to
91575d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_has_is_openlibrary method so that it doesn't return True if the library has no standard opening hours but has an exception closed date in the future.Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?