Add claim mechanism for periodical issues #3376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactors contacts block into `Vendor` resource. * Allow a new "serial" contact block * Adds alembic migration script * Adapts unitest and fixture Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Adds serial acquisition settings on `Library` resource to allow claim notification behavior/management. * Adds serial claim library dumpers. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Removes 'claims_count' fields from `Item` resource. * Removes legacy claim generation code. * Hides some not yet used field into the `Holding` JSONSchema for the `Holding` resource editor * Adds alembic script to remove `claims_count` field * Adds alembic script to update current `claimed` issue to `expected`. * Removes `claimed` status for an issue item. * Adapts the facets configuration for items (no more claimed status --> no more need to have a facet on issue_status). * Adapts CSV item serializers. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Creates claim issue notification type. * Creates claim issue notification templates. * Adds some unitest for claim notification. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Creates API to preview a claim notification content. * Creates API to create a real claim. * In the order preview API response, the recipient suggestions are exposed instead of data used to build the template. This is used by the UI preview component to use these address in the drag/drop section recipient section. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
* Adds claim notification information into ES data (for facetting) * Adds claim notification information for item `rero+json` serializer. * Forces `communication_language` field of `Vendor` resource as required field. * Add management of "cc" and "bcc" emails by notification dispatcher. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
Garfield-fr
reviewed
Jun 15, 2023
|
@Garfield-fr This is a feature branch with 6 commits umerged to staging. I don't think rebasing will lower the number of commits, right? |
@PascalRepond You need to rebase the 'US-2509-claim' branch to have just one commit. That would be nice because it's a feature. But you can also merge like this |
We don't usually squash commits from a feature branch as they represent development steps and have all been reviewed separately, why change? (recent examples: #3247, #3185) |
|
@PascalRepond For me, to have a clean history, we should have 1 commit per feature. But that's just my opinion. I'll validate... |
Garfield-fr
approved these changes
Jun 15, 2023
zannkukai
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you opening this PR?
Dependencies
My PR depends on the following
rero-ils-ui's PR(s):How to test?