library: detect changes on library open hours #3367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b545087 to
a85497e
Compare
jma
approved these changes
Jun 12, 2023
rerowep
reviewed
Jun 15, 2023
a85497e to
cdad917
Compare
rero_ils/modules/libraries/tasks.py
Outdated
| active_loan_counter += 1 | ||
| if not library.is_open(loan.end_date): | ||
| loan['end_date'] = library \ | ||
| .next_open(loan.end_date) \ |
There was a problem hiding this comment.
In the unlikely case where a library has no standard opening_hours and we created an exception open date in the past, next_open is going to get stuck in an infinite while loop.
With PR #3375, it will raise a LibraryNeverOpen exception. Maybe take this into account for added robustness?
lauren-d
approved these changes
Jun 20, 2023
cdad917 to
90e8043
Compare
* Creates extension to detect any changes into library calendar (regular hours & exception dates). If changes are detected, run this extension starts a tasks to update related loans. * Creates a task to update loans related a library if calendar changes. * Closes rero#2663. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
90e8043 to
7ec7808
Compare
PascalRepond
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
end_datewhen a closed date/period is added into library exceptions #2663.