8000 Error with role subfield when adding a contribution · Issue #3705 · rero/rero-ils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Error with role subfield when adding a contribution #3705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PascalRepond opened this issue Jun 12, 2024 · 1 comment · Fixed by rero/ng-core#629
Closed

Error with role subfield when adding a contribution #3705

PascalRepond opened this issue Jun 12, 2024 · 1 comment · Fixed by rero/ng-core#629
Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor

Comments

@PascalRepond
Copy link
Contributor
PascalRepond commented Jun 12, 2024 •
edited
Loading

Bug description:

Adding a contributor by duplicating anything but the last subfield creates an error TypeError: this.formControl.value is undefined and prevents me to select a role.

Expected behavior:

I should be able to duplicate any contributor from the list to add a new one wherever I want.

Steps to Reproduce:

  1. Edit this document https://ilsdev.test.rero.ch/professional/records/documents/detail/333
  2. Try to add a contribution after the last one : it works as intended
  3. Try to add a contribution after the first or second one : error in the console and impossible to select a role

Context

  • Versions: 1.22.1
@PascalRepond PascalRepond added the bug Breaks something but is not blocking label Jun 12, 2024
@PascalRepond PascalRepond added f: editor Concerns editor based on JSON schema AND custom editor bug (critical) Blocking issue, should be fixed ASAP bug Breaks something but is not blocking and removed bug Breaks something but is not blocking bug (critical) Blocking issue, should be fixed ASAP labels Jun 12, 2024
@PascalRepond PascalRepond moved this from Inbox to Sprint backlog in RERO ILS issues Jun 13, 2024
@PascalRepond
Copy link
Contributor Author

Depends on ngx-formly/ngx-formly#3957

@PascalRepond PascalRepond moved this from Sprint backlog to Ready to test in RERO ILS issues Jul 16, 2024
@PascalRepond PascalRepond moved this from Ready to test to In testing in RERO ILS issues Jul 17, 2024
PascalRepond added a commit to PascalRepond/ng-core that referenced this issue Jul 17, 2024
@PascalRepond
fix: update ngx-formly
feb7c8e 
- Closes rero/rero-ils#3712
- Closes rero/rero-ils#3705

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond mentioned this issue Jul 17, 2024
Merged
@github-project-automation github-project-automation bot moved this from In testing to Done in RERO ILS issues Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking f: editor Concerns editor based on JSON schema AND custom editor
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update ngx-formly PascalRepond/ng-core
1 participant
@PascalRepond
0