8000 Error if an item from a library without opening hours is checked out · Issue #2419 · rero/rero-ils · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Error if an item from a library without opening hours is checked out #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pronguen opened this issue Sep 28, 2021 · 0 comments · Fixed by #3375
Closed

Error if an item from a library without opening hours is checked out #2419

pronguen opened this issue Sep 28, 2021 · 0 comments · Fixed by #3375
Assignees
@PascalRepond
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend

Comments

@pronguen
Copy link
Contributor
pronguen commented Sep 28, 2021 •
edited
Loading

Describe the bug

Error if an item from a library without opening hours is checked out. This happens if the item is checked out from a library (transaction location)

Linked issue: #2318

To Reproduce

  1. Remove all opening hours in library X
  2. Checkout an item belonging to library X
    A) from a transaction location that has opening hours
    B) from a transaction location without opening hours
  3. See error

Technical error:
item_dumps = item.dumps_for_circulation() -> LibraryNeverOpen

Expected behavior

The checkout is realised/allowed

Note for case B): if no opening day is found in the 360 following days, the due date is computed without considering the opening days.

Context
@pronguen pronguen added f: circulation Concerns the circulation interface or backend bug Breaks something but is not blocking p-High High priority (to be solved in the 2-3 next months) labels Sep 28, 2021
@zannkukai zannkukai linked a pull request Sep 28, 2021 that will close this issue
notifications: generalize notification resource #2393
Merged
7 tasks
@zannkukai zannkukai removed a link to a pull request Sep 28, 2021
notifications: generalize notification resource #2393
Merged
7 tasks
@pronguen pronguen mentioned this issue Sep 29, 2021
Closed
@BadrAly BadrAly self-assigned this Oct 7, 2021
@BadrAly BadrAly linked a pull request Oct 7, 2021 that will close this issue
circulation: support non-circulating libraries #2431
Merged
7 tasks
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 15, 2021
circulation: support non-circulating libraries
b80fbf0 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.

* Supports checkout of items of libraries with no opening hours.
* Allows requests on items of non-circulating libraries at external
  locations.
* Closes rero#2367, rero#2419.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly mentioned this issue Oct 15, 2021
Merged
7 tasks
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 15, 2021
circulation: support non-circulating libraries
7cfd350 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

* Supports checkout of items of libraries with no opening hours.
* Allows requests on items of non-circulating libraries at external
  locations.
* Closes rero#2367, rero#2419.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@pronguen pronguen added p-Medium Medium priority (to be solved within 1-2 years) and removed p-High High priority (to be solved in the 2-3 next months) labels Oct 20, 2021
BadrAly pushed a commit to BadrAly/rero-ils that referenced this issue Oct 26, 2021
circulation: support non-circulating libraries
e907207 
The transaction locations of a library is selected in the list of pickup
locations of the library.  This causes issues with libraries that have
no pickup location setted.

With this commit, for libraries with no pickup locations the system
considers the first library location as transaction location for
circulation transactions. These libraries can now checkout items
directly from other libraries and once checked-in back they go
in_transit.
It is still mandatory to setup library hours and notification
settings before checkout items.

* Upgrades to invenio-circulation v1.0.0a34.
* Supports checkout of items of libraries with no opening hours.
* Fixes problem when in transit flash message was always displaying the pickup library.
* Allows requests on items of non-circulating libraries at external
  locations.
* Closes rero#2367, rero#2419.
* Adds a non-circulating library to units testing.

Co-Authored-by: Aly Badr <aly.badr@rero.ch>
@BadrAly BadrAly removed a link to a pull request Oct 28, 2021
circulation: support non-circulating libraries #2431
Merged
7 tasks
@PascalRepond PascalRepond added p-Low Low priority and removed p-Medium Medium priority (to be solved within 1-2 years) labels Mar 16, 2022
@BadrAly BadrAly removed their assignment Aug 22, 2022
@PascalRepond PascalRepond removed the p-Low Low priority label Mar 30, 2023
@PascalRepond PascalRepond moved this to Project Backlog in RERO ILS issues Mar 30, 2023
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jun 14, 2023
@PascalRepond
circulation: allow checkout from never open library
4a7e12a 
- in progress
- TODO: add a test
- Closes rero#2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jun 15, 2023
@PascalRepond
circulation: allow checkout from never open library
6b3a07e 
- Closes rero#2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jun 15, 2023
@PascalRepond
circulation: allow checkout from never open library
da2fca3 
- Closes rero#2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond mentioned this issue Jun 15, 2023
Merged
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jun 15, 2023
@PascalRepond
circulation: allow checkout from never open library
929cfa7 
- Closes rero#2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jun 15, 2023
@PascalRepond @jma
circulation: allow checkout from never open lib
70a9177 
- Fixes infinite loop when checking out an item from library without
open days but with open exception days.
- Fixes LibraryNeverOpen error not being passed to monitoring.
- Closes rero#2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jun 15, 2023
@PascalRepond @jma
circulation: allow checkout from never open lib
2edbce5 
- Fixes infinite loop when checking out an item from library without
open days but with open exception hours.
- Fixes `_has_is_open` returning True for exception open hours.
- Fixes LibraryNeverOpen error not being passed to monitoring.
- Fixes checkout not possible from library without opening hours.
- Closes rero#2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jun 15, 2023
@PascalRepond @jma
circulation: allow checkout from never open lib
ee210dc 
- Fixes infinite loop when checking out an item from library without
open days but with open exception hours.
- Fixes `_has_is_open` returning True for exception open hours.
- Fixes LibraryNeverOpen error not being passed to monitoring.
- Fixes checkout not possible from library without opening hours.
- Closes rero#2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jun 16, 2023
@PascalRepond @jma
circulation: allow checkout from never open lib
f80a166 
- Fixes infinite loop when checking out an item from library without
open days but with open exception hours.
- Changes `_has_is_open` to `has_open_day` function. It now returns
only returns True for exception dates without specified non-standard
hours.
- Fixes LibraryNeverOpen error not being passed to monitoring.
- Fixes checkout not possible from library without opening hours.
- Closes rero#2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jun 16, 2023
@PascalRepond @jma
circulation: allow checkout from never open lib
2de3530 
- Fixes infinite loop when checking out an item from library without
open days but with open exception hours.
- Changes `_has_is_open` to `has_open_day` function. It now returns
only returns True for exception dates without specified non-standard
hours.
- Fixes LibraryNeverOpen error not being passed to monitoring.
- Fixes checkout not possible from library without opening hours.
- Closes rero#2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jun 16, 2023
@PascalRepond @jma
circulation: allow checkout from never open lib
927bdc3 
- Fixes infinite loop when checking out an item from library without
open days but with open exception dates in the past.
- Add an extended validation to libraries to disallow open exception
dates without specifying times.
- Fixes LibraryNeverOpen error not being passed to monitoring.
- Fixes checkout not possible from library without opening hours.
- Closes rero#2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jun 16, 2023
@PascalRepond @jma
circulation: allow checkout from never open lib
df8e76b 
- Fixes infinite loop when checking out an item from library without
open days but with open exception dates in the past.
- Add an extended validation to libraries to disallow open exception
dates without specifying times.
- Fixes LibraryNeverOpen error not being passed to monitoring.
- Fixes checkout not possible from library without opening hours.
- Closes rero#2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jun 19, 2023
@PascalRepond @jma
circulation: allow checkout from never open lib
3afdc36 
- Fixes infinite loop when checking out an item from library without
open days but with open exception dates in the past.
- Add an extended validation to libraries to disallow open exception
dates without specifying times.
- Fixes LibraryNeverOpen error not being passed to monitoring.
- Fixes checkout not possible from library without opening hours.
- Closes rero#2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jun 19, 2023
@PascalRepond @jma
circulation: allow checkout from never open lib
9c0c25d 
- Fixes infinite loop when checking out an item from library without
open days but with open exception dates in the past.
- Add an extended validation to libraries to disallow open exception
dates without specifying times.
- Fixes LibraryNeverOpen error not being passed to monitoring.
- Fixes checkout not possible from library without opening hours.
- Closes rero#2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@PascalRepond PascalRepond moved this from Product Backlog to Ready to test in RERO ILS issues Jun 19, 2023
@PascalRepond PascalRepond self-assigned this Jun 19, 2023
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jun 19, 2023
@PascalRepond @jma
circulation: allow checkout from never open lib
0de3200 
- Fixes infinite loop when checking out an item from library without
open days but with open exception dates in the past.
- Add an extended validation to libraries to disallow open exception
dates without specifying times.
- Fixes LibraryNeverOpen error not being passed to monitoring.
- Fixes checkout not possible from library without opening hours.
- Closes rero#2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
PascalRepond added a commit that referenced this issue Jun 19, 2023
@PascalRepond @jma
circulation: allow checkout from never open lib
1c384b0 
- Fixes infinite loop when checking out an item from library without
open days but with open exception dates in the past.
- Add an extended validation to libraries to disallow open exception
dates without specifying times.
- Fixes LibraryNeverOpen error not being passed to monitoring.
- Fixes checkout not possible from library without opening hours.
- Closes #2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@PascalRepond PascalRepond moved this from Ready to test to In testing in RERO ILS issues Jun 19, 2023
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jun 19, 2023
@PascalRepond @jma
circulation: allow checkout from never open lib
d6c44d4 
- Fixes infinite loop when checking out an item from library without
open days but with open exception dates in the past.
- Add an extended validation to libraries to disallow open exception
dates without specifying times.
- Fixes LibraryNeverOpen error not being passed to monitoring.
- Fixes checkout not possible from library without opening hours.
- Closes rero#2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jun 20, 2023
@PascalRepond @jma
circulation: allow checkout from never open lib
cb24847 
- Fixes infinite loop when checking out an item from library without
open days but with open exception dates in the past.
- Add an extended validation to libraries to disallow open exception
dates without specifying times.
- Fixes LibraryNeverOpen error not being passed to monitoring.
- Fixes checkout not possible from library without opening hours.
- Closes rero#2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils that referenced this issue Jun 20, 2023
@PascalRepond @jma
circulation: allow checkout from never open lib
ed2e065 
- Fixes infinite loop when checking out an item from library without
open days but with open exception dates in the past.
- Add an extended validation to libraries to disallow open exception
dates without specifying times.
- Fixes LibraryNeverOpen error not being passed to monitoring.
- Fixes checkout not possible from library without opening hours.
- Closes rero#2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
PascalRepond added a commit that referenced this issue Jun 20, 2023
@PascalRepond @jma
circulation: allow checkout from never open lib
28d2285 
- Fixes infinite loop when checking out an item from library without
open days but with open exception dates in the past.
- Add an extended validation to libraries to disallow open exception
dates without specifying times.
- Fixes LibraryNeverOpen error not being passed to monitoring.
- Fixes checkout not possible from library without opening hours.
- Closes #2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@PascalRepond PascalRepond moved this from In testing to Approved in RERO ILS issues Jun 20, 2023
PascalRepond added a commit that referenced this issue Jun 20, 2023
@PascalRepond @jma
circulation: allow checkout from never open lib
f62801a 
- Fixes infinite loop when checking out an item from library without
open days but with open exception dates in the past.
- Add an extended validation to libraries to disallow open exception
dates without specifying times.
- Fixes LibraryNeverOpen error not being passed to monitoring.
- Fixes checkout not possible from library without opening hours.
- Closes #2419.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
@github-project-automation github-project-automation bot moved this from Approved to Done in RERO ILS issues Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PascalRepond PascalRepond

Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend
Projects
RERO ILS issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

circulation: allow checkout from never open library PascalRepond/rero-ils
3 participants
@pronguen @BadrAly @PascalRepond
0