8000 Improve project tooling by aron · Pull Request #2351 · replicate/cog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve project tooling #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 27, 2025
Merged

Improve project tooling #2351

merged 6 commits into from
May 27, 2025

Conversation

aron
Copy link
Contributor
@aron aron commented May 21, 2025

Based on the work done by @michaeldwan to move the project to uv and add a scripts directory, this PR takes this further providing common scripts for the most frequent tasks1. The benefit of using bash scripts rather than make tasks is the ability to easily pass in additional command line arguments to configure the tooling.

This PR adds:

  • script/format as an alias for make fmt (which now does go and python)
  • script/lint as an alias for make lint
  • script/test as a placeholder
  • script/test-all as an alias for make test
  • script/test-go to run the go tests
  • script/test-python to run the python tests for the primary python version

It also:

  • Moves ruff into dev dependencies rather than hardcoded versions in tox.ini so that developer tooling uses the same versions.
  • Adds python to the .tool-versions file to match .python-version this ensures that asdf and direnv will pick the right version.

aron added 5 commits May 21, 2025 09:03
This ensures that tools that support it will select the same Python
version as defined in the .python-version file.
This removes the outdated pinned version from tox.ini and ensures that
all tooling is using the same version of ruff.
@aron aron requested a review from michaeldwan May 21, 2025 09:57
@aron aron changed the title Set python version in .tools-version Improve project tooling May 21, 2025
Copy link
Member
@michaeldwan michaeldwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!!!

@aron aron merged commit e28fdf1 into main May 27, 2025
26 checks passed
@aron aron deleted the update-tool-versions branch May 27, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0