Call train function #2343
Call train function #2343
Conversation
* If the user makes a training request call the train function on the predictor class
48603c9 to
3ce6e50
Compare
There was a problem hiding this comment.
broadly looks good; my general worry here is that this might have unexpected consequences for our existing high volume trainers (e.g. a trainer that has train but no setup).
and to be clear, this is a worry driven by paranoia as opposed to anything I see here. 😄 do we have a test somewhere that would catch an issue with that kind of trainer?
Luckily setup is always optional so I bet that this won't matter so much |
trainwhen a class is defined in thetrainkey incog.yaml.This is a breaking change, since currently it calls
predictbut uses the type definition of thetrainmethod.