8000 Do not return an empty line by 8W9aG · Pull Request #2321 · replicate/cog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Do not return an empty line #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000
Merged
merged 1 commit into from
May 12, 2025
Merged

Do not return an empty line #2321

merged 1 commit into from
May 12, 2025

Conversation

8W9aG
Copy link
Contributor
@8W9aG 8W9aG commented May 12, 2025
  • Returning an empty line tells the scanner that we are finished.

@8W9aG
Do not return an empty line
efcbdb4 
* Returning an empty line tells the scanner that
we are finished.
@8W9aG 8W9aG requested review from michaeldwan, fofr and nevillelyh May 12, 2025 17:37
8000
@8W9aG 8W9aG merged commit dadc335 into main May 12, 2025
21 checks passed
@8W9aG 8W9aG deleted the sackfield/fix-scanner-empty-line branch May 12, 2025 17:51
danfairs pushed a commit to condensereality/cog that referenced this pull request May 14, 2025
@8W9aG @danfairs
Do not return an empty line (replicate#2321)
472c44f 
* Returning an empty line tells the scanner that
we are finished.
Signed-off-by: Dan Fairs <dan@condensereality.com>
danfairs pushed a commit to condensereality/cog that referenced this pull request May 14, 2025
@8W9aG @danfairs
Do not return an empty line (replicate#2321)
234cfa7 
* Returning an empty line tells the scanner that
we are finished.
Signed-off-by: Dan Fairs <dan@condensereality.com>
danfairs pushed a commit to condensereality/cog that referenced this pull request May 14, 2025
@8W9aG @danfairs
Do not return an empty line (replicate#2321)
3b9dbfd 
* Returning an empty line tells the scanner that
we are finished.
Signed-off-by: Dan Fairs <dan@condensereality.com>
danfairs pushed a commit to condensereality/cog that referenced this pull request May 14, 2025
@8W9aG @danfairs
Do not return an empty line (replicate#2321)
bbbf229 
* Returning an empty line tells the scanner that
we are finished.
Signed-off-by: Dan Fairs <dan@condensereality.com>
danfairs pushed a commit to condensereality/cog that referenced this pull request May 14, 2025
@8W9aG @danfairs
Do not return an empty line (replicate#2321)
f755dff 
* Returning an empty line tells the scanner that
we are finished.
Signed-off-by: Dan Fairs <dan@condensereality.com>
danfairs pushed a commit to condensereality/cog that referenced this pull request May 14, 2025
@8W9aG @danfairs
Do not return an empty line (replicate#2321)
584423a 
* Returning an empty line tells the scanner that
we are finished.
Signed-off-by: Dan Fairs <dan@condensereality.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldwan michaeldwan michaeldwan approved these changes

@fofr fofr Awaiting requested review from fofr

@nevillelyh nevillelyh Awaiting requested review from nevillelyh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8W9aG @michaeldwan
0