8000 Add OCI registry client by michaeldwan · Pull Request #2325 · replicate/cog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add OCI registry client #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 13, 2025
Merged

Add OCI registry client #2325

merged 7 commits into from
May 13, 2025

Conversation

michaeldwan
Copy link
Member
@michaeldwan michaeldwan commented May 13, 2025 •
edited
Loading

This replaces the docker.ManifestInspect function, which called docker manifest inspect, with a registry client decoupled from the daemon. The current usage is pretty much checking if a manifest exists (to determine if a r8 model exists) but we need registry manipulation for an upcoming PR, so here's a starting point.

Also adds

  • a test helper for booting a registry in tests that's preloaded with a handful of images
  • a utility to initialize a registry storage from scratch with a predefined set of images

@michaeldwan
move pickFreePort to util
e405867
@michaeldwan
registry_testhelpers package + util
99c866a 
- Helper for running a local registry w/ preloaded images in test environments.
- util for loading a set of predefined images into a clean registry storage
- update a few tests to use the test registry helper
@michaeldwan
restrict test registry port so docker insecure works
9578577
@michaeldwan
roughed in registry client & tests
acd79bc
@michaeldwan
replace docker manifest inspect with registry client
c016ac0
@michaeldwan
remove a few print statements that slipped through
c5000a8
@michaeldwan
skip registry tests in short mode
39ec285 
for now... GHA doesn't have rootless docker and i don't want to debug that now
@michaeldwan michaeldwan requested review from a team and 8W9aG May 13, 2025 19:57
@michaeldwan michaeldwan merged commit 4c8b448 into main May 13, 2025
38 of 39 checks passed
@micha 6870 eldwan michaeldwan deleted the md/docker-client-registry branch May 13, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8W9aG 8W9aG 8W9aG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeldwan @8W9aG
0