Move container ops to command.Command
#2307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2d2c4f1 to
89e81e4
Compare
danfairs
pushed a commit
to condensereality/cog
that referenced
this pull request
May 14, 2025
* update GetPort to use inspect, codegen mocks for tests
* move `run.{Run, RunWithIO, RunDaemon}` to `command.Command`
* pass streams to run
* debug message when generating schema
* split run/start operations, fix io streams
* remove print statement that's breaking tests
* remove commended out code
* remove internalRunOptions
* Force linux/amd64, remove RunOptions.Platform
* add TODO for passing host env to container by default
Signed-off-by: Dan Fairs <dan@condensereality.com>
danfairs
pushed a commit
to condensereality/cog
that referenced
this pull request
May 14, 2025
* update GetPort to use inspect, codegen mocks for tests
* move `run.{Run, RunWithIO, RunDaemon}` to `command.Command`
* pass streams to run
* debug message when generating schema
* split run/start operations, fix io streams
* remove print statement that's breaking tests
* remove commended out code
* remove internalRunOptions
* Force linux/amd64, remove RunOptions.Platform
* add TODO for passing host env to container by default
Signed-off-by: Dan Fairs <dan@condensereality.com>
danfairs
pushed a commit
to condensereality/cog
that referenced
this pull request
May 14, 2025
* update GetPort to use inspect, codegen mocks for tests
* move `run.{Run, RunWithIO, RunDaemon}` to `command.Command`
* pass streams to run
* debug message when generating schema
* split run/start operations, fix io streams
* remove print statement that's breaking tests
* remove commended out code
* remove internalRunOptions
* Force linux/amd64, remove RunOptions.Platform
* add TODO for passing host env to container by default
Signed-off-by: Dan Fairs <dan@condensereality.com>
danfairs
pushed a commit
to condensereality/cog
that referenced
this pull request
May 14, 2025
* update GetPort to use inspect, codegen mocks for tests
* move `run.{Run, RunWithIO, RunDaemon}` to `command.Command`
* pass streams to run
* debug message when generating schema
* split run/start operations, fix io streams
* remove print statement that's breaking tests
* remove commended out code
* remove internalRunOptions
* Force linux/amd64, remove RunOptions.Platform
* add TODO for passing host env to container by default
Signed-off-by: Dan Fairs <dan@condensereality.com>
danfairs
pushed a commit
to condensereality/cog
that referenced
this pull request
May 14, 2025
* update GetPort to use inspect, codegen mocks for tests
* move `run.{Run, RunWithIO, RunDaemon}` to `command.Command`
* pass streams to run
* debug message when generating schema
* split run/start operations, fix io streams
* remove print statement that's breaking tests
* remove commended out code
* remove internalRunOptions
* Force linux/amd64, remove RunOptions.Platform
* add TODO for passing host env to container by default
Signed-off-by: Dan Fairs <dan@condensereality.com>
danfairs
pushed a commit
to condensereality/cog
that referenced
this pull request
May 14, 2025
* update GetPort to use inspect, codegen mocks for tests
* move `run.{Run, RunWithIO, RunDaemon}` to `command.Command`
* pass streams to run
* debug message when generating schema
* split run/start operations, fix io streams
* remove print statement that's breaking tests
* remove commended out code
* remove internalRunOptions
* Force linux/amd64, remove RunOptions.Platform
* add TODO for passing host env to container by default
Signed-off-by: Dan Fairs <dan@condensereality.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is part of the ongoing work to abstract all docker cli calls behind the
command.Commandinterface. Once complete (almost there!) we can replace the cli client with one that connects directly to the daemon and exposes a swath of low level api calls we need.This PR:
ContainerInspectfunction to get a container port rather than thedocker portcommandmockeryto codegen interface mocks for testing (just giving it a try, works okay so far, will rip out if it's a pita)The only intentional change to behavior is that the entire host environment is no longer passed to containers by default. The motivation for this change is to reduce hard-to-debug foot guns caused by host env invisibly altering the container. Going forward the env passed to containers will be explicit.