8000 Prevent pydantic 2 clobbering by 8W9aG · Pull Request #2273 · replicate/cog · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Prevent pydantic 2 clobbering #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom 10000
Merged
merged 4 commits into from
Apr 24, 2025
Merged

Prevent pydantic 2 clobbering #2273

merged 4 commits into from
Apr 24, 2025

Conversation

8W9aG
Copy link
Contributor
@8W9aG 8W9aG commented Apr 22, 2025

8W9aG added 2 commits April 22, 2025 11:16
@8W9aG
Add granite integration test
5bf4713 
* Verify the behaviour of pydantic clobbering with
the IBM granite project
@8W9aG
Use the stated pydantic tolerances
534f084 
* We now support >=2 in pydantic so mirror the
tolerances we set in the toml
michaeldwan
michaeldwan approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member
@michaeldwan michaeldwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take this approval with a grain of salt... Change seems sensible, but I don't know enough about pedantic to understand the reason. :)

@8W9aG 8W9aG merged commit 2ce4fed into main Apr 24, 2025
21 checks passed
@8W9aG 8W9aG deleted the sackfield/no-pydantic-clobber branch April 24, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldwan michaeldwan michaeldwan approved these changes

@nevillelyh nevillelyh Awaiting requested review from nevillelyh

@NikhilSinha1 NikhilSinha1 Awaiting requested review from NikhilSinha1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't force pydantic to downgrade to <2
2 participants
@8W9aG @michaeldwan
0