Reduce Kafka per event logging to debug and include Kafka offset #3285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reduces per-event Kafka logging to debug level and enriches spans with the Kafka offset for better traceability.
- Lower per-message logs to
debugand includemessaging.kafka.offset - Add
#[instrument]todispatch_kafka_eventandtopic_partition_queue_consumption_loop - Simplify consumer task logging by removing
info_spanand using structureddebug!
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/ingress-kafka/src/dispatcher.rs | Updated import, added #[instrument(level = "debug", …)] to include offset |
| crates/ingress-kafka/src/consumer_task.rs | Switched from info_span to debug!, added instrumentation on loop, trimmed fields |
…ontroller This PR changes how the ClusterController learns about alive/dead nodes. Now it uses the restate_core::cluster_state::ClusterState to update the ObservedClusterState which is used by the LogsController and the Scheduler. As part of this commit, we hide the implementation details of the ObservedClusterState to allow for easier evolutions of it. Moreover, it simplifies the error handling of the LogsController by panicking if the loglet params cannot be parsed because it is a situation from which the Restate server cannot recover until the metadata gets fixed.
This commit improves a little bit the logging we do when consuming from Kafka. It reduces the per event log level to debug and includes the Kafka offset in spans/events for easier correlation what is being read.
e30634f to
397ab7d
Compare
|
I didn't verify it. Will do so and post a screenshot of the traces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves a little bit the logging we do when consuming from Kafka. It reduces the per event log level to debug and includes the Kafka offset in spans/events for easier correlation what is being read.