Add support for critical alerts #71
Conversation
|
@HarryET Bumping this, since it seems like you're the maintainer |
| fn get_options(&self) -> &NotificationOptions; | ||
| } | ||
|
|
||
| impl<'a> PayloadLike for Payload<'a> { |
There was a problem hiding this comment.
So... my company's app puts some data into the aps key of the payload (bad idea, we know, we're kinda stuck with it though so older versions of the app can still receive pushes). Doing it this way means we can insert our own stuff into aps:
#[derive(Serialize, Debug, Clone)]
struct APSWrapper<'a> {
r#type: &'a str,
#[serde(flatten)]
aps: APS<'a>,
}
#[derive(Serialize, Debug, Clone)]
struct Payload<'a> {
aps: APSWrapper<'a>,
details: IOSDetails<'a>,
#[serde(serialize_with = "bson::serde_helpers::serialize_object_id_as_hex_string")]
id: ObjectId,
#[serde(skip_serializing)]
device_token: &'a str,
#[serde(skip_serializing)]
options: NotificationOptions<'a>,
}
impl<'a> PayloadLike for Payload<'a> {
fn get_device_token(&self) -> &'a str {
self.device_token
}
fn get_options(&self) -> &NotificationOptions {
&self.options
}
}The other bit that's nice about this is it lets us enforce types on all the keys (since we impl Serialize)
This could probably be a derive macro, but I don't really know how to do that yet 😛
There was a problem hiding this comment.
🤔 We send custom data too, using .add_custom_data, does that not work for this case too? If not it might be nice to extract this change into a separate PR so it can be reviewed separate to supporting critical notifications
There was a problem hiding this comment.
add_custom_data won't let you add stuff inside the aps key
There was a problem hiding this comment.
I agree it would be nice to split it out into a separate PR, but the way I was writing my code (which was my smoke test) meant we needed to have this feature to make sure the whole chain worked
There was a problem hiding this comment.
Okay, I'm going to ping someone else internally to review as well then as this is a breaking change
|
@HarryET Made some changes... Let me know what you think! |
Very nice, makes |
Yes, because everything goes through |
Okay, a small test case might be nice but if it's already included by proxy that should be ok |
|
Any news on those reviews? |
Description
Serializeimplementations for the APNS payload. This means users can add custom fields inside theapskey (a bad idea for new software, but unfortunately we're kinda stuck with old apps that read custom data from weird places)How Has This Been Tested?
cargo testpassesaps.Due Dilligence
Not sure if I'm filling these out correctly:
PayloadLike. Maybe we could have dummy functions that replicate the functionality on the struct itself? Not sure if that'll work or if it's worth doing though)Would really love for someone to code review this and let me know if there's anything I can improve on!