Fix memory leak in RESP3 map parsing #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a memory leak in RESP3 map parsing by adjusting reference count management and error handling in the reader implementation. Key changes include:
- Adding new tests to stress-test memory leak scenarios and unhashable key handling.
- Fixing reference counting in the map parsing in src/reader.c.
- Updating dependencies and CI workflows to support memory profiling with memray.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_reader.py | New tests added for detecting memory leaks and unhashable keys. |
| src/reader.c | Adjusted reference counts and error handling in map parsing. |
| dev_requirements.txt | Updated test dependencies and added memray for memory profiling. |
| .github/workflows/integration.yaml | Added steps to install memray dependencies and set environment variables. |
| .github/workflows/freebsd.yaml | Updated pip installation to bypass memray on FreeBSD. |
Comments suppressed due to low confidence (1)
src/reader.c:87
- Consider adding error checking after the PyDict_SetItem call in the else branch (using last_key as key) to mirror the error handling in the if branch.
PyDict_SetItem(parent, last_key, obj);
StefanPalashev
approved these changes
May 7, 2025
petyaslavova
approved these changes
May 7, 2025
uglide
added a commit
to uglide/hiredis-py
that referenced
this pull request
May 9, 2025
* Fix memory leak in RESP3 map parsing Fix redis#175 * Add memray deps installation * Install deps only on ubuntu * Disable memray installation on Windows * Another attempt * Fix memray on old macOS versions * Disable memray for PyPy * Exclude FreeBSD * Revert * Another attempt for freebsd fix * Another attempt for freebsd fix (cherry picked from commit 7e77f22)
uglide
added a commit
that referenced
this pull request
May 9, 2025
* Fix memory leak in RESP3 map parsing (#204) * Fix memory leak in RESP3 map parsing Fix #175 * Add memray deps installation * Install deps only on ubuntu * Disable memray installation on Windows * Another attempt * Fix memray on old macOS versions * Disable memray for PyPy * Exclude FreeBSD * Revert * Another attempt for freebsd fix * Another attempt for freebsd fix (cherry picked from commit 7e77f22) * Version 3.1.1 * Run integration workflow on version branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #175