-
Notifications
You must be signed in to change notification settings - Fork 198
update for redisvl 0.6.0 #1524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update for redisvl 0.6.0 #1524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of suggestions, but minor stuff, so I'll approve.
* **Return type:** | ||
None | ||
|
||
#### `NOTE` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to render these notes in {{< note >}} ... {{< /note >}}
shortcodes instead of h4 headings? No major problem if not, but currently the notes appear as headings at the same level as the method names (although I doubt anyone will confuse them for methods).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should be wrapped in {{< note >}} ... {{< /note >}}
? Just the literal NOTE
or the whole thing?
* [Add route references](semantic_router/#add-route-references) | ||
* [Get route references](semantic_router/#get-route-references) | ||
* [Delete route references](semantic_router/#delete-route-references) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are subheadings of Semantic Routing, so should be indented (looks like they currently aren't indented):
* [Add route references](semantic_router/#add-route-references) | |
* [Get route references](semantic_router/#get-route-references) | |
* [Delete route references](semantic_router/#delete-route-references) | |
* [Add route references](semantic_router/#add-route-references) | |
* [Get route references](semantic_router/#get-route-references) | |
* [Delete route references](semantic_router/#delete-route-references) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is an existing problem, for instance for the Hash vs JSON Storage subheadings. I'll look into this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is caused by some inconsistencies in the redisvl jupyter notebooks. I'll open some prs to get those fixed at the source.
update for redisvl 0.6.0