feat: parallel rendering, make ffmpeg exporter default #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkonsti
reviewed
Apr 28, 2024
| const hiddenFolderId = uuidv4(); | ||
|
|
||
| /** | ||
| * TODO: Change this in the future after more testing. |
There was a problem hiding this comment.
I think we can delete this todo haha
| ); | ||
|
|
||
| renderPromises.push(renderVideoOnPage(browser, server, url)); | ||
| } |
There was a problem hiding this comment.
I think we're losing time here. Couldn't a browser start rendering right after it's ready? Right now the first one needs to wait for all the others before it can start.
|
|
||
| for (const folder of cleanupFolders) { | ||
| try { | ||
| await fs.promises.rm(folder, {recursive: true, force: true}); |
There was a problem hiding this comment.
We could parallelize this with an array and Promise.all(). Feel free to ignore this though, I don't think we would notice any difference.
packages/template/src/project.meta
Outdated
| @@ -13,15 +13,15 @@ | |||
| "audioOffset": 0 | |||
| }, | |||
| "preview": { | |||
| "fps": 60, | |||
| "fps": 30, | |||
There was a problem hiding this comment.
yeah, this makes the preview in the editor smoother
hkonsti
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.