Explicitly setting the git remote's URL when updating git dependencies #592
Conversation
2a7acb9 to
fee1a55
Compare
Otherwise, switching remotes for a dependency (as often happens e.g. when forking a github repo, then switching back again when the pull request gets merged by the upstream repo's maintainers) would typically break builds, with errors like: ``` sh(git checkout -q <git_reference>) failed with return code 128 and the following output: fatal: reference is not a tree: <git_reference> ```
fee1a55 to
695eb20
Compare
|
@wk8, I suppose you don't use rebar2 anymore, or else you would have pinged about the inactivity here. The diff looks reasonable to me and, if we are certain it won't negatively affect any scenario in the wild, I'd suggest a review+merge. |
|
@Tuncer yup we did switch to rebar3 a few months ago, but used this version of rebar2 till then, up to you if you want to review/merge, happy to do changes if the review warrants them :) |
|
In that case, do you mind extending the test suite? Given the potential to break scenarios in the wild, having tests for variations of git remote changes in deps is important. To that end, clone one of |
|
@Tuncer okay, will do soon, thanks |
|
Thinking about it, I haven't seen this reported anywhere else and, since you moved to rebar3, we could skip the patch and avoid potential regressions. |
Otherwise, switching remotes for a dependency (as often happens e.g. when forking
a github repo, then switching back again when the pull request gets merged by the
upstream repo's maintainers) would typically break builds, with errors like: