[NTOS:PS] Implement ProcessImageFileNameWin32 information class
#7942
+72
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HBelusca
reviewed
Apr 26, 2025
| ObjectNameInformation->Name.MaximumLength); | ||
| } else | ||
| { | ||
| ImageName->Buffer = NULL; |
There was a problem hiding this comment.
Maybe set also ImageName->Length = 0; just to be sure.
There was a problem hiding this comment.
I think it's unnecessary, because if MaximumLength is zero but Length is nonzero, this means IoQueryFileDosDeviceName went wrong.
There was a problem hiding this comment.
This is ReactOS, anything can go wrong :). Please put an ASSERT here.
f555d6a to
10a2aac
Compare
This build error seems not related to code. |
It's a usual glitch, we just need to retry the build. |
tkreuzer
reviewed
May 5, 2025
Comment on lines
+784
to
+785
| Length = ObjectNameInformation->Name.MaximumLength + sizeof(OBJECT_NAME_INFORMATION); | ||
| if (Length <= ProcessInformationLength) |
There was a problem hiding this comment.
This calculates the required size as string length + sizeof(OBJECT_NAME_INFORMATION), but below it copies a UNICODE_STRING + the string data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Implement
ProcessImageFileNameWin32information class ofNtQueryInformationProcess.JIRA issue: CORE-16145.
This issue is about
QueryFullProcessImageName, but this PR is the key to fix it.Proposed changes
ProcessImageFileNameWin32on NT6+ target.TODO
Apitest will be added on the further PR (about
QueryFullProcessImageName, WIP, not submitted yet).Testbot runs (Filled in by Devs)