Fix deadlock when multiple key lookups are coalessed and one of them throws an KeyNotFoundException #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else | ||
| { | ||
| elementMap[v].OnNext(Enumerable.Empty<CacheElement>()); | ||
| catch(KeyNotFoundException e) { |
There was a problem hiding this comment.
Given you do a ContainsKey() would this ever be hit?
There was a problem hiding this comment.
You check resultMap.ContainsKey(v) not true
Then you do a lookup with elementMap[v] with the same key, so yeah. A KeyNotFoundException could happen.
I don't remember the exact details. I just remember that this fix resolves a lot of crashy behaviour in my app on slow phones.
There was a problem hiding this comment.
Sorry,
The exception in the issue could have been created further down the reactive observables.
I should have copies the details of the exception back then.
glennawatson
approved these changes
Dec 26, 2018
|
Thanks for the pull request @jorisvergeer know it's been a while but finally in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Possible fix for #432
What is the current behavior? (You can also link to an open issue here)
See #432
What is the new behavior (if this is a feature change)?
No deadlock
Does this PR introduce a breaking change?
Possibly when the calling application depends on those deadlocks
Please check if the PR fulfills these requirements
Other information: