8000 react-jss not specified as any kind of dependency, but used in ThemeProvider · Issue #578 · react-page/react-page · GitHub

More Web Proxy on the site http://driver.im/

react-jss not specified as any kind of dependency, but used in ThemeProvider #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

davidfurlong opened this issue Aug 29, 2018 · 1 comment

Contributor

davidfurlong commented

It should probably be in https://github.com/ory/editor/blob/cc6ba2bb1e4b4f65649fd1928cdc8ce756732b66/packages/ui/package.json but I'm not sure whether it should be a peer or normal dependency.

Collaborator

aeneasr commented

That should be a peer-dependency! I'm wondering why MUI isn't importing that?

davidfurlong mentioned this issue

Update package.json #584

Merged

aeneasr closed this as completed in #584

aeneasr pushed a commit that referenced this issue


          ui: Add react-jss as peer dependency (#584)

595ce09

Closes #578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

0