8000 [Alternative 2] Make AddTypeToConstRector configurable to set inline_public config to allow non-final class to have typed constant by samsonasik · Pull Request #6975 · rectorphp/rector-src · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Alternative 2] Make AddTypeToConstRector configurable to set inline_public config to allow non-final class to have typed constant #6975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Alternative 2] Make AddTypeToConstRector configurable to set inline_public config to allow non-final class to have typed constant #6975

wants to merge 1 commit into from

Conversation

samsonasik
Copy link
Member
@samsonasik samsonasik commented Jun 11, 2025 •
edited
Loading

@TomasVotruba this is the 2nd alternative for

The make AddTypeToConstRector so user can define inline_public theirself when needed to allow non-final class to have typed constant only on the AddTypeToConstRector.

I prefer this option, as this feel less destructive, and more inline with other typed rules:

which has inline_public config that user can toggle on/off per specific rule.

@samsonasik
[Alternative 2] Make AddTypeToConstRector configurable to set inline_…
3dad3fc 
…public config to allow non-final class to have typed constant
This was referenced Jun 11, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsonasik
0