[Configuration] Fix root standalone registered rules verify on RectorConfigBuilder #6840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks have passed 🎉 @TomasVotruba it is ready for review 👍 |
|
Pretty neat solution 👏 Could you add simple test case, so we have this protected in case of future regressions? |
|
sure, I added test for it 👍 c001eb2 |
|
Let's merge 👍 |
|
Thank you 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ottsch @TomasVotruba this patch make ensure
ROOT_STANDALONE_REGISTERED_RULESonly sets once to avoid invalid merge whenRectorConfigBuilderis used in the config that included.Ref #6761 (comment)