8000 refactor (Text): Migrate Text to v1 in SDK by paanSinghCoder · Pull Request #994 · raystack/frontier · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor (Text): Migrate Text to v1 in SDK #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Op 8000 en
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

paanSinghCoder
Copy link
Contributor

No description provided.

Copy link
vercel bot commented May 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2025 11:00am

@coveralls
Copy link
coveralls commented May 20, 2025

Pull Request Test Coverage Report for Build 15135756915

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 33.339%

Totals Coverage Status
Change from base Build 15128900885: 0.0%
Covered Lines: 9865
Relevant Lines: 29590

💛 - Coveralls

@paanSinghCoder paanSinghCoder requested a review from rsbh May 20, 2025 10:17
@paanSinghCoder paanSinghCoder marked this pull request as ready for review May 20, 2025 10:17
@@ -193,7 +191,7 @@ const AddMemberDropdown = ({
} = await client?.frontierServiceListGroupUsers(
organization?.id,
teamId,
{ withRoles: true }
{ with_roles: true }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -239,7 +237,7 @@ const AddMemberDropdown = ({
if (!userId || !organization?.id) return;
try {
await client?.frontierServiceAddGroupUsers(organization?.id, teamId, {
userIds: [userId]
user_ids: [userId]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsbh Please confirm if this change is correct?

@@ -71,7 +70,7 @@ export const TeamPage = () => {
} = await client?.frontierServiceListGroupUsers(
organization?.id,
teamId,
{ withRoles: true }
{ with_roles: true }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsbh Please confirm if this change is correct?

@paanSinghCoder paanSinghCoder self-assigned this May 20, 2025
@paanSinghCoder paanSinghCoder changed the title refactor: import fixes refactor (EmptyState): Migrate EmptyState to v1 in SDK May 20, 2025
@paanSinghCoder paanSinghCoder changed the title refactor (EmptyState): Migrate EmptyState to v1 in SDK refactor (Text): Migrate Text to v1 in SDK May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0