10000 fix: make like and notlike case insensitive in User Search API by whoAbhishekSah · Pull Request #980 · raystack/frontier · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: make like and notlike case insensitive in User Search API #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

fix: make like and notlike case insensitive in User Search API #980

merged 1 commit into from
Apr 30, 2025

Conversation

whoAbhishekSah
Copy link
Member

Description

  • Make user search filter case insensitive by using postgres ilike/notilike operators
    • Improves UX by allowing case-insensitive text matching when filtering users

Testing

  • Test user search with mixed case input matches users regardless of case
  • Verify notlike operator also works case-insensitively
  • Check existing test cases pass with updated SQL queries

@vercel Vercel
Copy link
vercel bot commented Apr 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 8:25am

rohanchkrabrty
rohanchkrabrty approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor
@rohanchkrabrty rohanchkrabrty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whoAbhishekSah whoAbhishekSah merged commit 59ffa91 into main Apr 30, 2025
7 checks passed
@whoAbhishekSah whoAbhishekSah deleted the search_user_like_op branch April 30, 2025 08:30
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14750142282

Details

  • 2 of 5 (40.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 33.341%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/store/postgres/user_repository.go 2 5 40.0%
Totals Coverage Status
Change from base Build 14749854997: -0.004%
Covered Lines: 9865
Relevant Lines: 29588
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanchkrabrty rohanchkrabrty rohanchkrabrty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whoAbhishekSah @coveralls @rohanchkrabrty
0