chore: add debug logs to GetPrincipal #970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the GetPrincipal function by adding debug and error logging to improve traceability when fetching the principal.
- Added error logs for failures in retrieving session user and extracting session context.
- Inserted a debug log for cases where no client assertions match.
Comments suppressed due to low confidence (3)
core/authenticate/service.go:767
- [nitpick] Consider using a structured logging approach such as s.log.Errorf (if supported) to pass the error as a parameter instead of formatting it, thereby preserving the error context.
s.log.Error(fmt.Sprintf("unable to get session user by id: %v", err))
core/authenticate/service.go:777
- [nitpick] Similarly, consider using a structured logging method to log the session extraction error by directly passing the error to the logger if supported.
s.log.Error(fmt.Sprintf("unable to extract session from context: %v", err))
core/authenticate/service.go:902
- [nitpick] If possible, include additional context (such as input parameters or a summary of received assertions) in this debug log to help diagnose mismatches in client assertions.
s.log.Debug("none of the client assertions matched")
AmanGIT07
approved these changes
Apr 25, 2025
Pull Request Test Coverage Report for Build 14658185677Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.