8000 [Placement group] Refine doc by rkooo567 · Pull Request #10922 · ray-project/ray · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Placement group] Refine doc #10922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 23, 2020
Merged

[Placement group] Refine doc #10922

merged 4 commits into from
Sep 23, 2020

Conversation

rkooo567
Copy link
Contributor
@rkooo567 rkooo567 commented Sep 21, 2020 •
edited
Loading

Why are these changes needed?

Add more contents to placement group doc to clarify unclear parts.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

richardliaw
richardliaw reviewed Sep 22, 2020
View reviewed changes
richardliaw
richardliaw reviewed Sep 22, 2020
View reviewed changes
richardliaw
richardliaw reviewed Sep 22, 2020
View reviewed changes
richardliaw
richardliaw reviewed Sep 22, 2020
View reviewed changes
richardliaw
richardliaw reviewed Sep 22, 2020
View reviewed changes
richardliaw
richardliaw reviewed Sep 23, 2020
View reviewed changes
@rkooo567
Copy link
Contributor Author

cc @richardliaw Can you go through one more time?

@richardliaw richardliaw merged commit cebab88 into ray-project:master Sep 23, 2020
barakmich pushed a commit that referenced this pull request Sep 29, 2020
@rkooo567 @barakmich
[Placement group] Refine doc (#10922)
a302fb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkooo567 @richardliaw
0