[feat][python-client]: add rayjob support to kuberay python-client #3830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
andrewsykim
reviewed
Jun 24, 2025
kryanbeane
commented
Jun 25, 2025
| while timeout > 0: | ||
| status = self.get_ray_cluster_status( | ||
| name, k8s_namespace, timeout, delay_between_attempts | ||
| ) | ||
|
|
There was a problem hiding this comment.
Mostly formatting in this file, apart from this change. The status field for RayCluster has changed since this was implemented, and so the old version of this function did not actually wait for the Cluster to be ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Kuberay python-client has support for creating RayClusters. This change adds similar support to the client for Ray Jobs
Related issue number
3829
Checks