8000 [Fix] changelog-generator.py failed to parse some commit messages by MortalHappiness · Pull Request #3818 · ray-project/kuberay · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Fix] changelog-generator.py failed to parse some commit messages #3818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2025
Merged

[Fix] changelog-generator.py failed to parse some commit messages #3818

merged 1 commit into from
Jun 21, 2025

Conversation

MortalHappiness
Copy link
Member
@MortalHappiness MortalHappiness commented Jun 21, 2025 •
edited
Loading

Why are these changes needed?

As title.

The original script failed to handle this case because 3553 is an issue, not PR

22852028 [ray-operator][Bug] Rayjob is Failed or Succeed, but Raycluster status(jobDeploymentStatus) is still Running(#3553) (#3642)

Because the commit message always look like ... (#XXX), we can simply extract the PR number by splitting by # without using regex.

Follow-up:

See if we can resolve those cherry-picked commits automatically.

image

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@MortalHappiness
[Fix] changelog-generator.py failed to parse some commit messages
bed8bc1 
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness marked this pull request as draft June 21, 2025 03:14
@kevin85421
Copy link
Member

Is it ready for review? It is still a draft.

@MortalHappiness
Copy link
Member Author

Is it ready for review? It is still a draft.

I am still trying to resolve cherry-picked commits

@MortalHappiness MortalHappiness marked this pull request as ready for review June 21, 2025 11:35
@MortalHappiness
Copy link
Member Author

Update: I found it's hard to determine whether the PR is a cherry-pick commit or not, so I didn't handle this case and marked the PR as ready for review.
B4A2

kevin85421
kevin85421 approved these changes Jun 21, 2025
View reviewed changes
Copy link
Member
@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@kevin85421 kevin85421 merged commit 7d53e78 into ray-project:master Jun 21, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees

@kevin85421 kevin85421

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MortalHappiness @kevin85421
0