8000 [Docs] Add kubectl plugin create cluster sample yaml config files by MortalHappiness · Pull Request #3804 · ray-project/kuberay · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Docs] Add kubectl plugin create cluster sample yaml config files #3804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 20, 2025
Merged

[Docs] Add kubectl plugin create cluster sample yaml config files #3804

merged 3 commits into from
Jun 20, 2025

Conversation

MortalHappiness
Copy link
Member
@MortalHappiness MortalHappiness commented Jun 19, 2025 •
edited
Loading

Why are these changes needed?

As title. Related to #3225

Note that these sample yaml config files are placed in the kubectl-plugin folder, not ray-operator folder.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@MortalHappiness
[Docs] Add kubectl plugin create cluster sample yaml config files
e71f221 
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
kevin85421
kevin85421 reviewed Jun 19, 2025
View reviewed changes
kubectl-plugin/config/samples/create-cluster.complete.yaml Outdated
annotations:
dead: beef

ray-version: 2.44.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently, we use 2.46 for most YAMLs in this repo.

@kevin85421
Copy link
Member

cc @davidxia for review. Thanks!

@MortalHappiness
Address comment
4e2f7e5 
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness mentioned this pull request Jun 19, 2025
Merged
8 tasks
davidxia
davidxia reviewed Jun 19, 2025
View reviewed changes
Copy link
Contributor
@davidxia davidxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few additional fields, otherwise LGTM!

@MortalHappiness @davidxi 8000 a
Apply suggestions from code review
2641929 
Co-authored-by: David Xia <david@davidxia.com>
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@kevin85421 kevin85421 merged commit 8430410 into ray-project:master Jun 20, 2025
25 checks passed
MortalHappiness added a commit to MortalHappiness/kuberay that referenced this pull request Jun 20, 2025
@MortalHappiness @davidxia
[Docs] Add kubectl plugin create cluster sample yaml config files (ra…
2e11c2b 
…y-project#3804)

Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Co-authored-by: David Xia <david@davidxia.com>
MortalHappiness added a commit that referenced this pull request Jun 20, 2025
@MortalHappiness @davidxia
[Docs] Add kubectl plugin create cluster sample yaml config files (#3804
ee1a435 
) (#3813)

Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Co-authored-by: David Xia <david@davidxia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidxia davidxia davidxia approved these changes

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees

@kevin85421 kevin85421

Labels
1.4.0 release-blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MortalHappiness @kevin85421 @davidxia
0