8000 pass client when call batchscheduler.New() by KunWuLuan · Pull Request #3785 · ray-project/kuberay · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

pass client when call batchscheduler.New() #3785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pass client when call batchscheduler.New() #3785

wants to merge 1 commit into from

Conversation

KunWuLuan
Copy link
Contributor
@KunWuLuan KunWuLuan commented Jun 16, 2025 •
edited
Loading

Why are these changes needed?

Related issue number

For #3746

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@KunWuLuan KunWuLuan changed the title (WIP) pass client when call batchscheduler.New() pass client when call batchscheduler.New() Jun 21, 2025
@KunWuLuan
pass client when call batchscheduler.New()
732d3b3 
Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
@KunWuLuan
Copy link
Contributor Author

@kevin85421 Hi, please have a look when you have time. PR has been tested in local.

@kevin85421
Copy link
Member

cc @andrewsykim @rueian @MortalHappiness please take a look. Thanks.

rueian
rueian approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor
@rueian rueian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MortalHappiness
Copy link
Member

I also followed https://docs.ray.io/en/latest/cluster/kubernetes/k8s-ecosystem/volcano.html and verified that volcano works. I didn't test yunikorn and scheduler-plugins though. But generally LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rueian rueian rueian approved these changes

@MortalHappiness MortalHappiness MortalHappiness approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KunWuLuan @kevin85421 @MortalHappiness @rueian
0