[fix][operator] RayJob.Status.RayJobStatusInfo.EndTime nil deref error #3742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a nil pointer dereference when EndTime is nil in the status transition grace period check for RayJobs.
- Add a nil check for
EndTimebefore callingAdd(...). - Return early from
checkTransitionGracePeriodAndUpdateStatusIfNeeded()ifEndTimeis nil.
Comments suppressed due to low confidence (1)
ray-operator/controllers/ray/rayjob_controller.go:938
- Add a unit test for checkTransitionGracePeriodAndUpdateStatusIfNeeded that covers the case when EndTime is nil to prevent regressions.
if rayJob.Status.RayJobStatusInfo.EndTime == nil || time.Now().Before(rayJob.Status.RayJobStatusInfo.EndTime.Add(time.Duration(rayJobDeploymentGracePeriodTime)*time.Second)) {
kevin85421
approved these changes
Jun 4, 2025
If users run the latest ray-operator code from master branch without updating their RayJob CRD, the operator panics from a nil pointer dereference error in `rayjob_controller.go`. `rayJob.Status.RayJobStatusInfo.EndTime` is nil when a RayJob's Job fails with RayJob CRD from v1.3.2. We check if `EndTime` is nil and return false from `checkTransitionGracePeriodAndUpdateStatusIfNeeded()` if so. Signed-off-by: David Xia <david@davidxia.com>
pawelpaszki
pushed a commit
to opendatahub-io/kuberay
that referenced
this pull request
Jun 10, 2025
ray-project#3742) If users run the latest ray-operator code from master branch without updating their RayJob CRD, the operator panics from a nil pointer dereference error in `rayjob_controller.go`. `rayJob.Status.RayJobStatusInfo.EndTime` is nil when a RayJob's Job fails with RayJob CRD from v1.3.2. We check if `EndTime` is nil and return false from `checkTransitionGracePeriodAndUpdateStatusIfNeeded()` if so. Signed-off-by: David Xia <david@davidxia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If users run the latest ray-operator code from master branch without updating their RayJob CRD, the operator panics from a nil pointer dereference error in
rayjob_controller.go.rayJob.Status.RayJobStatusInfo.EndTimeis nil when a RayJob's Job fails with RayJob CRD from v1.3.2.We check if
EndTimeis nil and return false fromcheckTransitionGracePeriodAndUpdateStatusIfNeeded()if so.operator logs before shows panic
operator logs after shows no panic