8000 [Test] Fix unknown field warning by adding FieldValidationIgnore to Update call by nadongjun · Pull Request #3692 · ray-project/kuberay · GitHub

More Web Proxy on the site http://driver.im/

[Test] Fix unknown field warning by adding FieldValidationIgnore to Update call #3692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

nadongjun wants to merge 1 commit into ray-project:master from nadongjun:e2e/unknown

Contributor

nadongjun commented

Why are these changes needed?

The following warning was being emitted during tests using the Update() method on RayCluster:

This is because .Update() sends the full object including fields like creationTimestamp, which are managed by the Kubernetes API server and not expected in the spec. Unlike Apply(), the Update method doesn't omit empty or unset fields.

UpdateOptions{FieldValidation: metav1.FieldValidationIgnore}

to the Update() call, which suppresses warnings about unknown fields while preserving the intended behavior.

ref

https://github.com/kubernetes-sigs/controller-runtime/blob/7dfd3bb8edf29e12173a8c9b5843c2dced106955/pkg/client/options.go#L737-L753

Related issue number

Checks

I've made sure the tests are passing.
Testing Strategy
- Unit tests
- Manual tests
- This PR is not tested :(


          Fix unknown field warning by adding FieldValidationIgnore to Update call

24ce3c9

Signed-off-by: Dongjun Na <kmu5544616@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

0