src/dm: replace data size assertion by explicit gerror #1728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejoerns
reviewed
Jun 5, 2025
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (40.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #1728 +/- ##
==========================================
- Coverage 84.52% 84.51% -0.02%
==========================================
Files 76 76
Lines 22324 22328 +4
==========================================
+ Hits 18870 18871 +1
- Misses 3454 3457 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When using a modified raucb bundle with payload that is not a multiple of 4096, the following assertion happens: "rauc-CRITICAL **: r_dm_setup: assertion 'dm->data_size > 0 && dm->data_size % 4096 == 0' failed" Replace the assertion with a proper gerror failure. Fixes: rauc#1684 Reported-by: Tobias Graemer <tobias.graemer@mt.com> Signed-off-by: Janek Filus <janek.filus@mt.com>
35cf34c
B0E9
to
c966aef
Compare
ejoerns
approved these changes
Jun 5, 2025
jluebbe
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a modified raucb bundle with payload that is not a multiple of 4096, the following assertion happens:
"rauc-CRITICAL **: r_dm_setup: assertion 'dm->data_size > 0 && dm->data_size % 4096 == 0' failed"
Repalce the assertion with a proper gerror failure.
Fixes: #1684
Reported-by: Tobias Graemer tobias.graemer@mt.com
Signed-off-by: Janek Filus janek.filus@mt.com