Implement prefer IPv6 option for the client #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto issue/184-Prefer_IPv6
|
@fernvenue sry it took that long. I hope you could also test it :) |
|
there are some clippy warnings, where did not even touch the code, shall I also fix them? |
|
My pr touched the lines that clippy is complaining about, so I fixed them. Personally, I prefer it that way or in a separate cr, but I guess it's really up to the conventions that @rapiz1 wants. |
|
Hi @Stennsen, I just tested it on my devices, it works perfectly great :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #184
I tested it manually behind my ISP's Dual Stack lite with an external Server supporting both ipv4 and ipv6. Both A and AAAA registries were added for the tested domain.