8000 Default params by maciejhirsz · Pull Request #32 · ratel-rust/ratel-core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Default params #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 3, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "ratel"
version = "0.5.5"
version = "0.6.0"
authors = ["Maciej Hirsz <maciej.hirsz@gmail.com>"]
license = "MIT/Apache-2.0"
description = "JavaScript transpiler in Rust"
Expand Down
6 changes: 5 additions & 1 deletion core/src/codegen.rs
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,11 @@ impl Code for ObjectKey {
impl Code for Parameter {
#[inline]
fn to_code(&self, gen: &mut Generator) {
gen.write_bytes(self.name.as_bytes());
gen.write(&self.name);
if let Some(ref expression) = self.default {
gen.write_min(b" = ", b"=");
gen.write(expression);
}
}
}

Expand Down
4 changes: 2 additions & 2 deletions core/src/grammar.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ pub enum Value {
RawQuasi(OwnedSlice),
}


#[derive(Debug, PartialEq, Clone, Copy)]
#[derive(Debug, PartialEq, Clone)]
pub struct Parameter {
pub name: OwnedSlice,
pub default: Option<Box<Expression>>
}

#[derive(Debug, PartialEq, Clone, Copy)]
Expand Down
83 changes: 72 additions & 11 deletions core/src/parser.rs
Original file line number Diff line number Diff line change
Expand Up @@ -271,19 +271,62 @@ impl<'a> Parser<'a> {
fn arrow_function_expression(&mut self, p: Option<Expression>) -> Result<Expression> {
let params: Vec<Parameter> = match p {
None => Vec::new(),

Some(Expression::Identifier(name)) => {
vec![Parameter { name: name }]
vec![Parameter {
name : name,
default : None,
}]
},

Some(Expression::Binary {
parenthesized : true,
operator : Assign,
left,
right,
}) => {
let name = match *left {
Expression::Identifier(value) => value,
_ => unexpected_token!(self)
};

vec![Parameter {
name : name,
default : Some(right),
}]
},

Some(Expression::Sequence(mut list)) => {
let mut params = Vec::with_capacity(list.len());

for expression in list.drain(..) {
match expression {
params.push(match expression {
Expression::Binary {
operator: Assign,
left,
right,
..
} => {
let name = match *left {
Expression::Identifier(value) => value,
_ => unexpected_token!(self)
};

Parameter {
name : name,
default : Some(right),
}
},

Expression::Identifier(name) => {
params.push(Parameter { name: name });
Parameter {
name : name,
default : None
}
},

_ => unexpected_token!(self)
}
})
}

params
Expand Down Expand Up @@ -857,17 +900,35 @@ impl<'a> Parser<'a> {

fn parameter_list(&mut self) -> Result<Vec<Parameter>> {
let mut list = Vec::new();
let mut default_params = false;

loop {
match next!(self) {
let name = match next!(self) {
ParenClose => break,
Identifier(name) => {
list.push(Parameter {
name: name
});
},
Identifier(name) => name,
_ => unexpected_token!(self)
}
};

list.push(match peek!(self) {
Operator(Assign) => {
self.consume();
let expression = try!(self.expression(0));
default_params = true;
Parameter {
name: name,
default: Some(Box::new(expression))
}
}
_ => {
if default_params {
unexpected_token!(self);
}
Parameter {
name: name,
default: None
}
}
});

match next!(self) {
ParenClose => break,
Expand Down
Loading
0