8000 Complete Migration of IVF Helpers / Features from RAFT by tarang-jain · Pull Request #213 · rapidsai/cuvs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Complete Migration of IVF Helpers / Features from RAFT #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Jul 30, 2024
Merged

Complete Migration of IVF Helpers / Features from RAFT #213

merged 41 commits into from
Jul 30, 2024

Conversation

tarang-jain
Copy link
Contributor

Utils / Helpers to enable FAISS migration to cuVS from RAFT.

tarang-jain and others added 18 commits June 25, 2024 14:50
@tarang-jain
update build API
7cdbcd1
@tarang-jain
updates to docstring;update index_params
7f3ccef
@tarang-jain
cleanup;add extract_centers
4575e22
@tarang-jain
Merge branch 'branch-24.08' of https://github.com/rapidsai/cuvs into …
0cdff12 
…faiss-reqs
@tarang-jain
update function signature;update docs
b4da8b3
@tarang-jain
update docs
61a120f
@tarang-jain
update index params
6dcb3dc
@tarang-jain
Merge branch 'branch-24.08' of https://github.com/rapidsai/cuvs into …
7040e31 
…expose-public-api
@cjnolet
Merge branch 'branch-24.08' into faiss-reqs
ad122b9
@tarang-jain
Merge branch 'branch-24.08' into faiss-reqs
1193c6b
@tarang-jain
first commit
96241d1
@tarang-jain
merge faiss-reqs
a2988ae
@tarang-jain
Merge branch 'expose-public-api' of https://github.com/tarang-jain/cuvs…
4fe85cf 
… into faiss-combined
@tarang-jain
rename param
20efe4c
@tarang-jain
update docs
bc7dc61
@tarang-jain
all changes
122d181
@tarang-jain
updates after reviews
00137b7
@tarang-jain
Merge branch 'branch-24.08' of https://github.com/rapidsai/cuvs into …
25d0ac2 
…faiss-combined
@github-actions github-actions bot added the cpp label Jul 5, 2024
This was referenced Jul 5, 2024
Closed
Closed
@tarang-jain tarang-jain added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jul 5, 2024
@github-actions github-actions bot added the CMake label Jul 15, 2024
@tarang-jain tarang-jain self-assigned this Jul 22, 2024
@tarang-jain tarang-jain changed the title Complete Importing of IVF Helpers / Features from RAFT Complete Migration of IVF Helpers / Features from RAFT Jul 23, 2024
@tarang-jain tarang-jain requested a review from a team as a code owner July 24, 2024 17:51
@tarang-jain tarang-jain requested a review from raydouglass July 24, 2024 17:51
@copy-pr-bot copy-pr-bot
Copy link
copy-pr-bot bot commented Jul 24, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@tarang-jain
Copy link
Contributor Author

/ok to test

tfeher
tfeher approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor
@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tarang for the update, LGTM!

@cjnolet
Copy link
Member
cjnolet commented Jul 30, 2024

/merge

@tarang-jain
Copy link
Contributor Author

/ok to test

@raydouglass raydouglass removed request for a team and raydouglass July 30, 2024 17:11
@rapids-bot rapids-bot bot merged commit 6658c31 into rapidsai:branch-24.08 Jul 30, 2024
54 checks passed
divyegala pushed a commit to divyegala/cuvs that referenced this pull request Jul 31, 2024
@tarang-jain @divyegala
Complete Migration of IVF Helpers / Features from RAFT (rapidsai#213)
dfafba2 
Utils / Helpers to enable FAISS migration to cuVS from RAFT.

Authors:
  - Tarang Jain (https://github.com/tarang-jain)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Tamas Bela Feher (https://github.com/tfeher)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#213
@tarang-jain tarang-jain mentioned this pull request Aug 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@tfeher tfeher tfeher approved these changes

Assignees

@tarang-jain tarang-jain

Labels
CMake cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
3FBF
Development

Successfully merging this pull request may close these issues.
3 participants
@tarang-jain @cjnolet @tfeher
0