Fix IVF-PQ helper functions #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
reviewed
May 14, 2024
cjnolet
reviewed
May 14, 2024
| @@ -1,9 +1,9 @@ | |||
| /* | |||
| * raft::copyright (c) 2022-2024, NVIDIA CORPORATION. | |||
| * Copyright (c) 2022-2024, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
I didn't notice this one before. That's a great search and replace snafu. This one just made my day.
cjnolet
reviewed
May 14, 2024
cjnolet
reviewed
May 15, 2024
Co-authored-by: Corey J. Nolet <cjnolet@gmail.com>
cjnolet
approved these changes
May 16, 2024
cjnolet
reviewed
May 16, 2024
| /** | ||
| * @} | ||
| */ | ||
| }; // namespace codepacker |
There was a problem hiding this comment.
I think there's a few functions below that are part of the codepackager also
There was a problem hiding this comment.
We should do this as a follow-on just to make sure we can get the main bits merged.
cjnolet
approved these changes
8000
May 17, 2024
|
@lowener I was otherwise thinking we should move the additional codepacker functions into codepacker namespace in a follow up, but since this PR requires fixing merge conflicts anyways, I think we should just go ahead and do that move here. |
|
/merge |
difyrrwrzd
added a commit
to difyrrwrzd/cuvs
that referenced
this pull request
Aug 10, 2024
Some IVF-PQ helper functions needed for FAISS were missing. Authors: - Micka (https://github.com/lowener) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai/cuvs#116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some IVF-PQ helper functions needed for FAISS were missing.