Instantiate only specific RAFT linewise kernels #1018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
aamijar
commented
Jun 12, 2025
| FORK ${RAFT_FORK} | ||
| PINNED_TAG ${RAFT_PINNED_TAG} | ||
| FORK aamijar | ||
| PINNED_TAG compile-time-invocation |
tarang-jain
requested changes
Jun 18, 2025
| true, | ||
| raft::min_op{}, | ||
| stream); | ||
| raft::linalg::matrixVectorOp<true, true>(minDistBuf.data_handle(), |
There was a problem hiding this comment.
IIRC the camel case one was being deprecated? Looks like we are using both -- matrix_vector_op and matrixVectorOp. Can we stick to matrix_vector_op?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on rapidsai/raft#2701 and Resolves rapidsai/raft#2682