Add tiered_index support #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
cjnolet
reviewed
May 8, 2025
| /** @copydoc extend */ | ||
| void extend(raft::resources const& handle, | ||
| raft::device_matrix_view<const float, int64_t, raft::row_major> new_vectors, | ||
| tiered_index::index<ivf_flat::index<float, int64_t>>* idx); |
There was a problem hiding this comment.
I'm assuming this is using the already instantiated APIs, but I wonder if we could eventually get away with just int64 types (not just in this API but across all the index apis).
cjnolet
reviewed
May 8, 2025
cjnolet
reviewed
May 8, 2025
|
/ok to test 981f9c6 |
cjnolet
approved these changes
May 29, 2025
|
/merge |
mythrocks
pushed a commit
to mythrocks/cuvs
that referenced
this pull request
Jun 3, 2025
Authors: - Ben Frederickson (https://github.com/benfred) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.