[FIX] Revert negated InnerProduct distance for NN Descent #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok to test |
@jinsolp, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
|
/ok to test a602546 |
benfred
reviewed
May 2, 2025
| if (build_config_.metric == cuvs::distance::DistanceType::L2SqrtExpanded) { | ||
| raft::linalg::map( | ||
| res, output_dist_view, raft::sqrt_op{}, raft::make_const_mdspan(output_dist_view)); | ||
| } else if (build_config_.metric == cuvs::distance::DistanceType::InnerProduct) { |
There was a problem hiding this comment.
nitpick: Can we use the is_min_close function here instead of checking for IP distance itself?
Suggested change
| } else if (build_config_.metric == cuvs::distance::DistanceType::InnerProduct) { | |
| } else if (!cuvs::distance::is_min_close(build_config_.metric)) { |
|
/ok to test 5e68d85 |
benfred
approved these changes
May 7, 2025
|
/ok to test d23835a |
|
/ok to test 5891601 |
8000
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #849
Many parts of NN Descent is written on top of the assumption that smaller distance is closer.
Therefore, using the current trick (using -(dot product) values) to make it consistent with other metrics to be sorted in ascending order, then negating the value at the end should be the neatest solution.